Code Review for webrev.sed

Prepared by:Garrett D'Amore <garrett@nexenta.com> on 2010-Dec-15 12:08 -0800 PST
Workspace:/export/work/tr (at 634b5053a004)
Compare against: ssh://anonhg@hg.illumos.org/illumos-gate (at 4f23f0abcff2)
Summary of changes: 3864 lines changed: 3855 ins; 5 del; 4 mod; 8387 unchg
Patch of changes: webrev.sed.patch
Printable review: webrev.sed.pdf

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/Makefile.lint 

508 od doesn't set text domain
509 need an open source sed(1) replacement
1 line changed: 1 ins; 0 del; 0 mod; 521 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/Makefile 

508 od doesn't set text domain
509 need an open source sed(1) replacement
1 line changed: 1 ins; 0 del; 0 mod; 864 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/mdb/tools/scripts/tigen.sh 

Fix incorrect escape of } in tigen.  (Worked with old version of sed,
but not with new, even though it was technically in error.)
2 lines changed: 0 ins; 1 del; 1 mod; 167 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/cmd/od/od.c 

508 od doesn't set text domain
509 need an open source sed(1) replacement
6 lines changed: 6 ins; 0 del; 0 mod; 915 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sed/Makefile 

508 od doesn't set text domain
509 need an open source sed(1) replacement
53 lines changed: 53 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sed/POSIX 

508 od doesn't set text domain
509 need an open source sed(1) replacement
204 lines changed: 204 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sed/THIRDPARTYLICENSE 

508 od doesn't set text domain
509 need an open source sed(1) replacement
31 lines changed: 31 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sed/THIRDPARTYLICENSE.descrip 

508 od doesn't set text domain
509 need an open source sed(1) replacement
1 line changed: 1 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sed/compile.c 

508 od doesn't set text domain
509 need an open source sed(1) replacement
931 lines changed: 931 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sed/defs.h 

508 od doesn't set text domain
509 need an open source sed(1) replacement
150 lines changed: 150 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sed/extern.h 

508 od doesn't set text domain
509 need an open source sed(1) replacement
62 lines changed: 62 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sed/main.c 

508 od doesn't set text domain
509 need an open source sed(1) replacement
Fix getln() for large lines.
520 lines changed: 520 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sed/misc.c 

508 od doesn't set text domain
509 need an open source sed(1) replacement
82 lines changed: 82 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sed/process.c 

508 od doesn't set text domain
509 need an open source sed(1) replacement
766 lines changed: 766 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sed/sed.1 

508 od doesn't set text domain
509 need an open source sed(1) replacement
636 lines changed: 636 ins; 0 del; 0 mod; 0 unchg

------ ------ ------ ------ ------ --- New Patch Raw usr/src/cmd/sed/sed.txt 

508 od doesn't set text domain
509 need an open source sed(1) replacement
391 lines changed: 391 ins; 0 del; 0 mod; 0 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/head/regex.h 

508 od doesn't set text domain
509 need an open source sed(1) replacement
1 line changed: 1 ins; 0 del; 0 mod; 181 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/engine.c 

508 od doesn't set text domain
509 need an open source sed(1) replacement
5 lines changed: 0 ins; 3 del; 2 mod; 1148 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/lib/libc/port/locale/regcomp.c 

516 libc regex misses \< and \> word delimiters
17 lines changed: 16 ins; 0 del; 1 mod; 1739 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/SUNWcs.mf 

508 od doesn't set text domain
509 need an open source sed(1) replacement
2 lines changed: 2 ins; 0 del; 0 mod; 2743 unchg

Cdiffs Udiffs Wdiffs Sdiffs Frames Old New Patch Raw usr/src/pkg/manifests/system-xopen-xcu4.mf 

508 od doesn't set text domain
509 need an open source sed(1) replacement
2 lines changed: 1 ins; 1 del; 0 mod; 109 unchg

This code review page was prepared using /opt/onbld/bin/webrev. Webrev is maintained by the illumos project. The latest version may be obtained here.